Fix unhandled ResultSet.json errors, prepare 1.6.0 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
changed the title
|
mshustov
reviewed
Sep 12, 2024
| } | ||
| }) | ||
| stream.on('end', resolve) | ||
| stream.on('error', reject) |
There was a problem hiding this comment.
This is the exact part that produced unhandled exceptions.
for await (const rows of stream) {
for (const row of rows) {
result.push(row.json())
}
}achieves the same on the modern Node.js versions, but we can catch the error properly on the app side.
mshustov
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #309
Checklist